Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 3/3] RFC: p9auth: add p9auth fs | Date | Tue, 04 May 2010 15:57:17 +0100 |
| |
Serge E. Hallyn <serue@us.ibm.com> wrote:
> + result = kzalloc(MAX_DIGEST_SIZE, GFP_KERNEL); > ... > + ret = crypto_hash_digest(&desc, &sg, plain_text_size, result);
Does result have to be pre-cleared?
> + user_buf = kzalloc(count+1, GFP_KERNEL); > + if (!user_buf) > + goto out; > + > + if (copy_from_user(user_buf, buffer, count)) {
user_buf doesn't need preclearing. It's just a waste of time. This occurs three times.
David
| |