Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 1/3] p9auth: split core function out of some set*{u,g}id functions | Date | Tue, 04 May 2010 15:52:19 +0100 |
| |
Serge E. Hallyn <serue@us.ibm.com> wrote:
> Break the core functionality of set{fs,res}{u,g}id into cred_setX > which performs the access checks based on current_cred(), but performs > the requested change on a passed-in cred. > > Export the helpers, since p9auth can be compiled as a module. It > might be worth not allowing modular p9auth to avoid having to export > them. > > Really the setfs{u,g}id helper isn't needed, but move it as > well to keep the code consistent. > > This patch also changes set_user() to use new->user->user_ns. While > technically not needed as all callers should have new->user->user_ns > equal to current_userns(), it is more correct and may prevent surprises > in the future. > > Changelog: > Apr 24: (David Howells) make cred_setresuid etc extern, and > document the helpers in Documentation/credentials.txt. > > Signed-off-by: Serge E. Hallyn <serue@us.ibm.com> Acked-by: David Howells <dhowells@redhat.com>
| |