lkml.org 
[lkml]   [2010]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Oprofile: Change CPUIDS from decimal to hex, and add some comments
On 16.04.10 13:08:49, John Villalovos wrote:
> Back when the patch was submitted for "Add Xeon 7500 series support to
> oprofile", Robert Richter had asked for a follown patch that converted
> all the CPU ID values to hex.
>
> I have done that here for the processors in the ppro_init() function and also
> added some documentation as comments that I retrieved from the Intel Software
> Developer's Manual (SDM) March 2010 edition in Volume 3B, Table B-1.
>
> The Intel SDM can be found at:
> http://www.intel.com/products/processor/manuals/
>
> I also added processor codenames for some of the newer processors.

John,

I don't want to change previous cpu models and keep it as it is. So I
am fine with updating i386/core_i7 and i386/atom to avoid mixed dec
and hex notations.

Please also remove the comments that describe the model as it will be
hard to maintain this, if there are questions one should read the
spec. So please also add some more details of the specification source
to the patch description, I think it is:

Table B-1. CPUID Signature Values of DisplayFamily_DisplayModel

in SDM Volume 3B.

Use lower case hex values instead.

Add your Signed-off-by please.

Thanks,

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com



\
 
 \ /
  Last update: 2010-05-04 16:09    [W:0.031 / U:7.176 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site