lkml.org 
[lkml]   [2010]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] sunrpc: add missing return statement
From
Date
Trond Myklebust wrote:
> > > No. It should either be a BUG_ON(), or else be removed entirely.
> > > Returning an error value for something that is clearly a programming bug
> > > is not a particularly useful exercise...
> > >
> > Removing NULL check is wrong because it will NULL pointer dereference later.
>
> Wrong. Removing NULL check is _right_ because calling this function
> without setting up a back channel first is a major BUG. Returning an
> error value to the user is pointless, since the user has no control over
> this. It is entirely under control of the sunrpc developers...
>
For security people, removing

if (!args->bc_xprt)
ERR_PTR(-EINVAL);

is worse and changing to

BUG_ON(!args->bc_xprt);

is better.


\
 
 \ /
  Last update: 2010-05-04 16:05    [W:0.095 / U:15.496 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site