Messages in this thread | | | Date | Mon, 31 May 2010 14:06:48 +0900 | Subject | Re: [RFC] oom-kill: give the dying task a higher priority | From | Minchan Kim <> |
| |
Hi, Kosaki.
On Sat, May 29, 2010 at 12:59 PM, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > Hi > >> oom-killer: give the dying task rt priority (v3) >> >> Give the dying task RT priority so that it can be scheduled quickly and die, >> freeing needed memory. >> >> Signed-off-by: Luis Claudio R. Gonçalves <lgoncalv@redhat.com> > > Almostly acceptable to me. but I have two requests, > > - need 1) force_sig() 2)sched_setscheduler() order as Oleg mentioned > - don't boost priority if it's in mem_cgroup_out_of_memory()
Why do you want to not boost priority if it's path of memcontrol?
If it's path of memcontrol and CONFIG_CGROUP_MEM_RES_CTLR is enabled, mem_cgroup_out_of_memory will select victim task in memcg. So __oom_kill_task's target task would be in memcg, I think.
As you and memcg guys don't complain this, I would be missing something. Could you explain it? :)
-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |