Messages in this thread | | | Date | Mon, 31 May 2010 23:07:48 +0200 | From | Dan Carpenter <> | Subject | Re: [patch 2/2] input/tps6507x-ts: zero vs NULL |
| |
On Mon, May 31, 2010 at 12:10:29PM -0700, Dmitry Torokhov wrote: > On Mon, May 31, 2010 at 02:02:15PM +0200, Dan Carpenter wrote: > > --- a/drivers/input/touchscreen/tps6507x-ts.c > > +++ b/drivers/input/touchscreen/tps6507x-ts.c > > @@ -342,7 +342,7 @@ err2: > > cancel_delayed_work(&tsc->work); > > flush_workqueue(tsc->wq); > > destroy_workqueue(tsc->wq); > > - tsc->wq = 0; > > + tsc->wq = NULL; > > input_free_device(input_dev); > > err1: > > kfree(tsc); > > @@ -364,7 +364,7 @@ static int __devexit tps6507x_ts_remove(struct platform_device *pdev) > > cancel_delayed_work(&tsc->work); > > flush_workqueue(tsc->wq); > > Why isn't it cancel_delayed_work_sync()? >
Good point.
> > destroy_workqueue(tsc->wq); > > - tsc->wq = 0; > > + tsc->wq = NULL; > > > > Setting tsc to 0/NULL does not make much sense as it is being freed a > couple of lines below. >
That's true. I'll send an updated patch tomorrow.
regards, dan carpenter
| |