Messages in this thread | | | Date | Mon, 31 May 2010 20:04:46 +0200 | From | Oleg Nesterov <> | Subject | Re: [RFC] [PATCH 2/2] cgroups: make procs file writable |
| |
On 05/31, Oleg Nesterov wrote: > > I only glanced into one function, cgroup_attach_proc(), and some things > look "obviously wrong". Sorry, I can't really read these patches now, > most probably I misunderstood the code...
And, forgot to mention, I do not understand the PF_EXITING check in attach_task_by_pid() (and some others).
At first glance, it buys nothing. PF_EXITING can be set right after the check. And, what if we have the process with the exited group-leader? In that case we can't use tgid to move this process?
Oleg.
| |