lkml.org 
[lkml]   [2010]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] netfilter: xtables: stackptr should be percpu

On Monday 2010-05-31 15:13, Eric Dumazet wrote:
>
>All cpus share a single cache line for their 'stackptr' storage,
>introduced in commit f3c5c1bfd4
>
>This is a stable candidate (2.6.34)

Stackptr was first introduced for 2.6.35-rcX.

>+ i->stackptr = alloc_percpu(unsigned int);
> if (i->stackptr == NULL)
> return -ENOMEM;
>- memset(i->stackptr, 0, size);
>
> size = sizeof(void **) * nr_cpu_ids;
> if (size > PAGE_SIZE)

Are alloc_percpu areas cleared?

Acked-By: Jan Engelhardt <jengelh@medozas.de>



\
 
 \ /
  Last update: 2010-05-31 15:25    [W:0.442 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site