lkml.org 
[lkml]   [2010]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-pm] [patch] complain when users abuse the pm_qos API
On Sun, May 30, 2010 at 09:03:18AM +1000, Nigel Cunningham wrote:
> Hi.
>
> On 30/05/10 06:08, Rafael J. Wysocki wrote:
> >On Saturday 29 May 2010, mark gross wrote:
> >>The following patch is to help clean up API abusers of pm_qos where
> >>they call update_request before registering a request.
> >>
> >>--mgross
> >>
> >>--Signed-off-by: markgross<markgross@thegnar.org>
> >
> >Will there be a big issue if I push this during the next merge window?
>
> What's the point to the patch? That is: why is calling
> update_request before registering a request such a big problem that
> it demands a WARN() and dump stack?

If e1000e realy needs the latency set and makes assumptions that its
done its part, I would like to let them know that they have not
registerd the request they thought they did.

--mgross

>
> Regards,
>
> Nigel


\
 
 \ /
  Last update: 2010-05-30 22:09    [W:1.036 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site