Messages in this thread | | | From | (Eric W. Biederman) | Date | Sun, 30 May 2010 08:09:02 -0700 | Subject | Re: [PATCH] proc_dointvec, write a single value |
| |
David Miller <davem@davemloft.net> writes:
> From: Cong Wang <amwang@redhat.com> > Date: Tue, 25 May 2010 20:23:47 +0800 > >> On 05/25/10 14:49, J. R. Okajima wrote: >>> The commit 00b7c3395aec3df43de5bd02a3c5a099ca51169f >>> "sysctl: refactor integer handling proc code" >>> modified the behaviour of writing to /proc. >>> Before the commit, write("1\n") to /proc/sys/kernel/printk >>> succeeded. But >>> now it returns EINVAL. >>> >>> This commit supports writing a single value to a multi-valued entry. >>> >>> Signed-off-by: J. R. Okajima<hooanon05@yahoo.co.jp> >> >> Reviewed-and-tested-by: WANG Cong <amwang@redhat.com> > > Since the regression causing change came in via the net tree > I'll integrate this fix too, applied, thanks!
Thanks, guys for fixing this.
I hate to see my review comments show up like this in practice. I had really hoped those unnecessary changes to proc would have been dropped from that patchset. Oh well.
Eric
| |