Messages in this thread | | | Date | Sun, 30 May 2010 20:10:24 -0700 | From | Arjan van de Ven <> | Subject | Re: Documentation/timers/hpet_example.c compile bug |
| |
On Sun, 30 May 2010 19:58:38 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On 05/30/10 19:49, Arjan van de Ven wrote: > > On Sun, 30 May 2010 19:34:35 -0700 > > Randy Dunlap <randy.dunlap@oracle.com> wrote: > >> > >> Does it even make sense to build hpet_example on s390? > >> I.e., does s390 have hpet? > >> If not, then a simple Kconfig "depends on X86" or "depends > >> on !S390" will fix this. > > > > HPET is very PC specific. > > > > but.. even on x86, it does not really make sense, and exposing this > > as an interface to userspace is a historical mistake, the use of > > which we really ought to discourage. > > Do you mean exposing anything that is in /usr/include/linux/hpet.h > via ioctls? especially struct hpet_info ?
exposing even the concept of HPET, so yeah, including that header. not all systems have hpet.. and frankly, we have better interfaces for the same functionality...
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |