lkml.org 
[lkml]   [2010]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/8] arch/tile: header files for the Tile architecture.
    From
    On Fri, 28 May 2010 23:10:07 -0400
    Chris Metcalf <cmetcalf@tilera.com> wrote:

    > This includes the relevant Linux headers in asm/; the low-level
    > low-level "Tile architecture" headers in arch/, which are
    > shared with the hypervisor, etc., and are build-system agnostic;
    > and the relevant hypervisor headers in hv/.
    >
    > Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>

    (snip)

    > +++ b/arch/tile/include/asm/dma-mapping.h
    > @@ -0,0 +1,106 @@
    > +/*
    > + * Copyright 2010 Tilera Corporation. All Rights Reserved.
    > + *
    > + * This program is free software; you can redistribute it and/or
    > + * modify it under the terms of the GNU General Public License
    > + * as published by the Free Software Foundation, version 2.
    > + *
    > + * This program is distributed in the hope that it will be useful, but
    > + * WITHOUT ANY WARRANTY; without even the implied warranty of
    > + * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
    > + * NON INFRINGEMENT. See the GNU General Public License for
    > + * more details.
    > + */
    > +
    > +#ifndef _ASM_TILE_DMA_MAPPING_H
    > +#define _ASM_TILE_DMA_MAPPING_H
    > +
    > +/*
    > + * IOMMU interface. See Documentation/PCI/PCI-DMA-mapping.txt and
    > + * Documentation/DMA-API.txt for documentation.
    > + */

    Documentation/PCI/PCI-DMA-mapping.txt was renamed to
    Documentation/DMA-API-HOWTO. Anyway, I recommend removing the useless
    comment.


    > +#include <linux/mm.h>
    > +#include <linux/scatterlist.h>
    > +#include <linux/cache.h>
    > +#include <linux/io.h>
    > +
    > +/*
    > + * Note that on x86 and powerpc, there is a "struct dma_mapping_ops"
    > + * that is used for all the DMA operations. For now, we don't have an
    > + * equivalent on tile, because we only have a single way of doing DMA.
    > + */

    I think that using "struct dma_mapping_ops" is a good idea even if you
    support the single dma ops. You can avoid lots of duplicated code.


    (snip)

    > --- /dev/null
    > --- /dev/null
    > +++ b/arch/tile/include/asm/scatterlist.h
    > @@ -0,0 +1 @@
    > +#include <asm-generic/scatterlist.h>

    Did you compile this patchset with 2.6.35-rc1? I think that you need
    to define ISA_DMA_THRESHOLD here.


    \
     
     \ /
      Last update: 2010-05-31 05:01    [W:0.022 / U:0.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site