Messages in this thread | | | Date | Mon, 3 May 2010 10:13:13 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 0/5] perf inject + say no to __KERNEL__ only stuff |
| |
From: Ingo Molnar <mingo@elte.hu> Date: Mon, May 03, 2010 at 09:37:49AM +0200
> It broke half of the non-x86 architectures. For example on Sparc defconfig: > > In file included from /home/mingo/tip/include/asm-generic/bitops/hweight.h:4, > from /home/mingo/tip/arch/sparc/include/asm/bitops_32.h:103, > from /home/mingo/tip/arch/sparc/include/asm/bitops.h:6, > from /home/mingo/tip/include/linux/bitops.h:17, > from /home/mingo/tip/include/linux/kernel.h:15, > from /home/mingo/tip/include/linux/sched.h:54, > from /home/mingo/tip/arch/sparc/kernel/asm-offsets.c:13: > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight32': > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:8: error: implicit declaration of function '__sw_hweight32' > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight16': > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:13: error: implicit declaration of function '__sw_hweight16' > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight8': > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:18: error: implicit declaration of function '__sw_hweight8' > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight64': > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:23: error: implicit declaration of function '__sw_hweight64' > > (the failure on other architectures looks similar)
Looks like we're missing the __sw_hweightXX prototype definitions in that include maze. Ingo, which -tip branch is that and can you put it somewhere for me to test?
Thanks.
-- Regards/Gruss, Boris.
| |