lkml.org 
[lkml]   [2010]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/30] viafb: use proper pci config API
    [One I never answered]

    On Sat, 01 May 2010 16:01:30 +0200
    Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:

    > I fear this check is wrong as
    >
    > struct viafb_par {
    > ...
    > unsigned int memsize;
    > ...
    > }
    >
    > so this check would as far as I see never return true *wonders why gcc
    > doesn't complain about it*

    That is wrong, yes. As it happens, this gets fixed later in the series
    when things move into via-core.c. I'd like to say that it's because I
    noticed the problem and dealt with it, but you're smarter than that,
    alas...

    Thanks,

    jon


    \
     
     \ /
      Last update: 2010-05-04 04:39    [W:0.048 / U:0.320 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site