lkml.org 
[lkml]   [2010]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mm: fix race between shift_arg_pages and rmap_walk


On Mon, 3 May 2010, Linus Torvalds wrote:
>
> It looks like it makes execve() do a totally insane "create and then
> immediately destroy temporary vma and anon_vma chain" for a case that is
> unlikely to ever matter.
>
> In fact, for a case that isn't even normally _enabled_, namely migration.
>
> Why would we want to slow down execve() for that?

Alternate suggestions:

- clean up the patch so that it is explicitly abouy migration, and
doesn't even get enabled for anything else.

- make the migration code take the VM lock for writing (why doesn't it
already?) and never race with things like this in the first place.

- explain why the new code isn't any slower.

Hmm?

Linus


\
 
 \ /
  Last update: 2010-05-03 18:41    [from the cache]
©2003-2011 Jasper Spaans