Messages in this thread Patch in this message | | | Subject | Re: mmotm 2010-04-28 - RCU whinges | From | Eric Dumazet <> | Date | Mon, 03 May 2010 18:14:53 +0200 |
| |
Le lundi 03 mai 2010 à 08:43 -0700, Paul E. McKenney a écrit :
> Highly recommended. ;-) > > And thanks to you for your testing efforts and to Eric for the fixes!!! >
For this last one, I think you should push following patch Paul
Followup of commit 3120438ad6 (rcu: Disable lockdep checking in RCU list-traversal primitives)
Or we might introduce a hlist_for_each_entry_continue_rcu_bh() macro...
diff --git a/include/linux/rculist.h b/include/linux/rculist.h index 004908b..b0c7e24 100644 --- a/include/linux/rculist.h +++ b/include/linux/rculist.h @@ -435,10 +435,10 @@ static inline void hlist_add_after_rcu(struct hlist_node *prev, * @member: the name of the hlist_node within the struct. */ #define hlist_for_each_entry_continue_rcu(tpos, pos, member) \ - for (pos = rcu_dereference((pos)->next); \ + for (pos = rcu_dereference_raw((pos)->next); \ pos && ({ prefetch(pos->next); 1; }) && \ ({ tpos = hlist_entry(pos, typeof(*tpos), member); 1; }); \ - pos = rcu_dereference(pos->next)) + pos = rcu_dereference_raw(pos->next)) #endif /* __KERNEL__ */
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |