[lkml]   [2010]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 3/4]: sendfile: remove flags paramter of do_splice_direct()
On Sun, May 30, 2010 at 8:39 AM, Steven Rostedt <> wrote:
> Probably because I copied the code from something that used

From the relay API implementation?

> But userspace passes that flag too. Although, maybe I just don't
> understand the API fully.

this flag is a little confusing. It is much like:

flags = fcntl(pipe_fd, F_GETFL);
fcntl(pipe_fd, F_SETFL, flags | O_NONBLOCK);
splice(..pipe_fd..., 0); // without O_NONBLOCK
fcntl(pipe_fd, F_SETFL, falgs);

In fact, setting O_NONBLOCK is the only way of letting splice pipe
operations non-blockable currently. When splicing, splice doesn't
refer to the pipe file's f_flags. :(

Changli Gao(
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2010-05-30 05:27    [W:0.043 / U:0.660 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site