Messages in this thread | | | Date | Fri, 28 May 2010 09:04:01 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 1/4] Add targets to use the Coccinelle checker |
| |
On Wed, May 12, 2010 at 02:42:30PM +0800, Américo Wang wrote: > On Mon, May 10, 2010 at 06:24:24PM +0200, Nicolas Palix wrote: > >Four targets are added. Each one generates a different > >output kind: context, patch, org, report. > >Every SmPL file in 'scripts/coccinelle' is given to the spatch frontend > >(located in the 'scripts' directory), and applied to the entire > >source tree. > > > >Signed-off-by: Nicolas Palix <npalix@diku.dk> > >Signed-off-by: Julia Lawall <julia@diku.dk> > > This is great!
Totally agreed.
> I would like to see coccinelle to be integrated with kbuild, but the > name 'coccicheck' is really confusing, how about 'sema_check'? Which > means 'semantic check'.
I think its okay to keep coccicheck because its the name of the tool called. We do the same with 'make cscope'. But since I am a bit lazy I would prefer a shorter name, probably just 'make cocci'?
> Or we can use something like for sparse, i.e. 'make C=1' etc..
Yes, this would also make sense. As a developer I could add this and only the code I changed is checked.
Joerg
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |