lkml.org 
[lkml]   [2010]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched_clock: Provide local_clock() and improve documentation
From
Date
On Fri, 2010-05-28 at 15:42 +0200, Johannes Stezenbach wrote:
> On Fri, May 28, 2010 at 03:13:34PM +0200, Peter Zijlstra wrote:
> > + * The !IRQ-safetly of sched_clock() and sched_clock_cpu() comes from things
>
> typo ^
>
> Thank you for adding documentation. I have one additional
> question regarding wrapping of sched_clock(). I know it is
> used for timestamps in ftrace and printk, so it's desirable
> that it never wraps. But on several embedded systems
> it wraps after a few hours. Bug or just a minor flaw?
> If someone knows it would be nice to get that documented, too.

The scheduler assumes it wraps at u64, however since we mostly use it to
compute a time deltas it mostly works, even when it wraps sooner, its
just that we get large jumps once in a while when it does wraps, due to
(s64)(new - old) not ending up being a proper s64.

If you have CONFIG_HAVE_UNSTABLE_SCHED_CLOCK, these jumps will be
filtered out and polished over.


\
 
 \ /
  Last update: 2010-05-28 17:11    [W:0.074 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site