lkml.org 
[lkml]   [2010]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 3/4]: sendfile: remove flags paramter of do_splice_direct()
On Fri, May 28, 2010 at 5:40 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> On Wed, 26 May 2010, Changli Gao wrote:
>> remove flags paramter of do_splice_direct().
>>
>> the flags parameter of do_splice_direct() doesn't mean non-block read of
>> in file,
>
> Actually, it does.  Look at the SPLICE_F_NONBLOCK usage in
> __generic_splice_file_read().
>

Oh, I checked the code again. You're right. However, why don't we
check the flags of in file instead in __generic_file_splice_read()?

--
Regards,
Changli Gao(xiaosuo@gmail.com)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-05-28 12:09    [W:1.774 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site