lkml.org 
[lkml]   [2010]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC] oom-kill: give the dying task a higher priority
Date
Hi Luis,

> On 05/27, Luis Claudio R. Goncalves wrote:
> >
> > It sounds plausible giving the dying task an even higher priority to be
> > sure it will be scheduled sooner and free the desired memory.
>
> As usual, I can't really comment the changes in oom logic, just minor
> nits...
>
> > @@ -413,6 +415,8 @@ static void __oom_kill_task(struct task_struct *p, int verbose)
> > */
> > p->rt.time_slice = HZ;
> > set_tsk_thread_flag(p, TIF_MEMDIE);
> > + param.sched_priority = MAX_RT_PRIO-1;
> > + sched_setscheduler(p, SCHED_FIFO, &param);
> >
> > force_sig(SIGKILL, p);
>
> Probably sched_setscheduler_nocheck() makes more sense.
>
> Minor, but perhaps it would be a bit better to send SIGKILL first,
> then raise its prio.

I have no objection too. but I don't think Oleg's pointed thing is minor.
Please send updated patch.

Thanks.




\
 
 \ /
  Last update: 2010-05-28 04:57    [W:0.082 / U:1.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site