Messages in this thread | | | Date | Thu, 27 May 2010 20:22:46 -0400 (EDT) | From | Len Brown <> | Subject | Re: [PATCH 8/8] intel_idle: create a native cpuidle driver for select intel processors |
| |
> >> > drivers/idle/intel_idle.c | 446
> >> Any reason this arch-specific driver needs to be in drivers/idle > >> instead of under a platform specific dir like arch/x86?
> To me that would be much less convenient as I expect to maintain my > platform-specific CPUidle driver along with the rest of my > platform-specific code.
I guess the reason is conveneince of the maintainer (me).
A good case could be made to put this driver under drivers/cpuidle/, arch/x86/, drivers/platform/x86/, as well as drivers/idle/ -- and maybe someplace else that I didn't think of.
Maybe if I maintained all of arch/x86/, then I'd naturally propose putting it someplace under arch/x86/. But like i7300_idle, it runs on only a sub-set of x86 boxes, so it seemed to make sense to put it with i7300_idle.
BTW. There is an sfi_idle driver in the pipeline as well with the same naming issue. It is x86 specific, sfi-specific, and cpuidle-specific -- so a case could be made to put it in arch/x86/, drivers/sfi/, drivers/cpuidle/ -- but it will just as likely land in drivers/idle/.
cheers, Len Brown, Intel Open Source Technology Center
| |