lkml.org 
[lkml]   [2010]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] Btrfs updates


On Thu, 27 May 2010, Chris Mason wrote:
>
> fs/btrfs/extent-tree.c | 2317 ++++++++++++++++++++++++++++--------------------
> fs/btrfs/relocation.c | 1991 +++++++++++++++++++++++++----------------
> fs/btrfs/inode.c | 1797 +++++++++++++++++++++++++++++--------
> fs/btrfs/file.c | 304 +++---
> fs/btrfs/tree-log.c | 241 +++-
> ...

What kind of bogus diffstat is this?

Don't do that. I cannot compare your bogus diffstat with what I get,
because it's just random noise. You've apparently sorted it by size of the
damage, but the numbers are total crap too. That is _not_ the actual size
of the changes at all.

I suspect you have some script that adds up all the patches, but that's
wrong. If a subsequent patch changes the things that an earlier patch has
done, then the numbers don't just add up.

And if the diffstat doesn't match what I get when I pull, then my reaction
inevitably is "ok, that's not what they asked me to pull, so I'll just
reject it out-of-hand". So don't play games with diffstats - that just
means that things won't get pulled.

Linus


\
 
 \ /
  Last update: 2010-05-27 19:23    [W:0.156 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site