lkml.org 
[lkml]   [2010]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH-v2 2/8] cpuidle: add cpuidle_unregister_driver() error check
On Thu, 27 May 2010 01:11:03 -0400 (EDT) Len Brown <lenb@kernel.org> wrote:

> From: Len Brown <len.brown@intel.com>
>
> BUG_ON() cpuidle_unregister_driver() being called with
> a driver not matching the onee that successfully registered.
>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
> drivers/cpuidle/driver.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c
> index 2257004..5b6fd0f 100644
> --- a/drivers/cpuidle/driver.c
> +++ b/drivers/cpuidle/driver.c
> @@ -45,8 +45,7 @@ EXPORT_SYMBOL_GPL(cpuidle_register_driver);
> */
> void cpuidle_unregister_driver(struct cpuidle_driver *drv)
> {
> - if (!drv)
> - return;
> + BUG_ON(drv != cpuidle_curr_driver)
>
> spin_lock(&cpuidle_driver_lock);
> cpuidle_curr_driver = NULL;

Actually, WARN_ON is nicer ;) There's no point in killing the user's
machine over this recoverable error.



\
 
 \ /
  Last update: 2010-05-27 07:15    [W:0.036 / U:6.608 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site