lkml.org 
[lkml]   [2010]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [PATCH 6/7] scsi: megaraid_sas - Add three times Online controller reset - V2
    Tomas/James,

    > Also descriptive subjects would be nice (parts I-III may do well for
    > Lord of the Rings ... it's less useful for SCSI patches).
    >
    >This is again a question for the original author. Bo?

    I changed the description and resubmit them already.

    Bo Yang



    -----Original Message-----
    From: Tomas Henzl [mailto:thenzl@redhat.com]
    Sent: Wednesday, May 26, 2010 11:48 AM
    To: James Bottomley
    Cc: Yang, Bo; 'linux-scsi@vger.kernel.org'; 'akpm@osdl.org'; 'linux-kernel@vger.kernel.org'; Daftardar, Jayant
    Subject: Re: [PATCH 6/7] scsi: megaraid_sas - Add three times Online controller reset - V2

    On 05/25/2010 07:32 PM, James Bottomley wrote:
    > On Tue, 2010-05-25 at 18:17 +0200, Tomas Henzl wrote:
    >
    >> V2: I've cleaned up some coding style issues and removed a variable, the functionality shouldn't be changed
    >>
    >> Tomas
    >>
    >> If fw didn't raise the interrupt with the fw state change to driver and fw goes to failure state, driver
    >> Will check the FW state in driver's timeout routine and issue the reset if need. Driver will do the OCR upto three
    >> Times until kill adapter. Also driver will issue OCR before driver kill adapter even if fw in operational state.
    >>
    > So there's supposed to be a replacement for 3/7 (megaraid_sas - Online
    > COntroller Reset (OCR) PART-III) as well, isn't there?
    >
    Yes, I think there are some issues that could be removed, on the other side
    it is mostly coding style related, so I think it could be accepted as it is.
    I hope I could afterwards clean something up. (The patches as they are now don't
    apply correctly on my system, it's maybe an issue with my mail reader.)


    > Also descriptive subjects would be nice (parts I-III may do well for
    > Lord of the Rings ... it's less useful for SCSI patches).
    >
    This is again a question for the original author. Bo?

    Tomas


    > James
    >
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    >

    \
     
     \ /
      Last update: 2010-05-26 23:11    [W:0.028 / U:0.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site