Messages in this thread Patch in this message | | | Date | Wed, 26 May 2010 17:58:53 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH 15/17] fs/ocfs2/dlm: Add missing spin_unlock |
| |
From: Julia Lawall <julia@diku.dk>
Add a spin_unlock missing on the error path. Unlock as in the other code that leads to the leave label.
The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression E1; @@
* spin_lock(E1,...); <+... when != E1 if (...) { ... when != E1 * return ...; } ...+> * spin_unlock(E1,...); // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- fs/ocfs2/dlm/dlmdomain.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c index 6b5a492..2ccad86 100644 --- a/fs/ocfs2/dlm/dlmdomain.c +++ b/fs/ocfs2/dlm/dlmdomain.c @@ -1709,6 +1709,7 @@ retry: } if (dlm_protocol_compare(&dlm->fs_locking_proto, fs_proto)) { + spin_unlock(&dlm_domain_lock); mlog(ML_ERROR, "Requested locking protocol version is not " "compatible with already registered domain "
| |