Messages in this thread | | | Date | Tue, 25 May 2010 14:33:23 +0200 | From | Carsten Emde <> | Subject | Re: [PATCH 2/4] tracing/sched: Fix task states in sched switch event |
| |
Hi Ingo,
>>> Hm, this is totally unreadable. What does 'TASK_STATE_X' mean?? >> Would this be better? >> +#define MAKE_TASK_STATE_STRING(num) TASK_STATE_##num " (" DESCR_TASK_STATE_##num ")" >> static const char *task_state_array[] = { >> - "R (running)", /* 0 */ >> - "S (sleeping)", /* 1 */ >> - "D (disk sleep)", /* 2 */ >> - "T (stopped)", /* 4 */ >> - "t (tracing stop)", /* 8 */ >> - "Z (zombie)", /* 16 */ >> - "X (dead)", /* 32 */ >> - "x (dead)", /* 64 */ >> - "K (wakekill)", /* 128 */ >> - "W (waking)", /* 256 */ >> + MAKE_TASK_STATE_STRING(0), >> + MAKE_TASK_STATE_STRING(1), >> + MAKE_TASK_STATE_STRING(2), >> + MAKE_TASK_STATE_STRING(4), >> + MAKE_TASK_STATE_STRING(8), >> + MAKE_TASK_STATE_STRING(16), >> + MAKE_TASK_STATE_STRING(32), >> + MAKE_TASK_STATE_STRING(64), >> + MAKE_TASK_STATE_STRING(128), >> + MAKE_TASK_STATE_STRING(256) > > The whole enumeration there is pointless in that .c file - it tells nothing to > the code reader. > > If it cannot be expressed in a meaningful way then introduce > TASK_STATE_STRINGS_INIT construct that is defined next to the strings (in a .h > file or so) - that way it's a coherent whole. This is what I did and submitted some time ago. Is there anything else you want me to change?
Thanks,
Carsten.
| |