[lkml]   [2010]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 3/3] dm: lookup devices by path with name_to_dev_t
On Mon, May 24 2010 at 12:35pm -0400,
Will Drewry <> wrote:

> On Mon, May 24, 2010 at 10:07 AM, Alasdair G Kergon <> wrote:
> > On Mon, May 24, 2010 at 09:44:07AM -0500, Will Drewry wrote:
> >> fwiw, the only reason for the copy was because |path| is a
> >> const in the function but not when passed to name_to_dev_t.
> >> I wasn't sure what the preferred practice was so I just duped
> >> the data needed.
> >
> > Well check that it is treated as 'const' and send a separate patch to
> > the maintainer to add const, perhaps?  If it isn't const (why would
> > that be?), then yes we'd need to copy it.
> I'll cross-check the code again and send a patch out if it looks like
> it is const-safe.

Also, it would see that name_to_dev_t is EXPORT_SYMBOL?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2010-05-25 01:39    [W:0.059 / U:12.980 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site