lkml.org 
[lkml]   [2010]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[02/39] hp_accel: fix race in device removal

    2.6.33-stable review patch. If anyone has any objections, please let us know.

    ------------------
    From: Oliver Neukum <oneukum@suse.de>

    commit 06efbeb4a47b6f865e1c9d175ab9d6e90b69ae9e upstream.

    The work queue has to be flushed after the device has been made
    inaccessible. The patch closes a window during which a work queue might
    remain active after the device is removed and would then lead to ACPI
    calls with undefined behavior.

    Signed-off-by: Oliver Neukum <oneukum@suse.de>
    Acked-by: Eric Piel <eric.piel@tremplin-utc.net>
    Acked-by: Pavel Machek <pavel@ucw.cz>
    Cc: Pavel Herrmann <morpheus.ibis@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/hwmon/hp_accel.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/hwmon/hp_accel.c
    +++ b/drivers/hwmon/hp_accel.c
    @@ -324,8 +324,8 @@ static int lis3lv02d_remove(struct acpi_
    lis3lv02d_joystick_disable();
    lis3lv02d_poweroff(&lis3_dev);

    - flush_work(&hpled_led.work);
    led_classdev_unregister(&hpled_led.led_classdev);
    + flush_work(&hpled_led.work);

    return lis3lv02d_remove_fs(&lis3_dev);
    }



    \
     
     \ /
      Last update: 2010-05-25 01:35    [W:4.117 / U:1.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site