lkml.org 
[lkml]   [2010]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[25/39] inotify: dont leak user struct on inotify release

    2.6.33-stable review patch. If anyone has any objections, please let us know.

    ------------------
    From: Pavel Emelyanov <xemul@openvz.org>

    commit b3b38d842fa367d862b83e7670af4e0fd6a80fc0 upstream.

    inotify_new_group() receives a get_uid-ed user_struct and saves the
    reference on group->inotify_data.user. The problem is that free_uid() is
    never called on it.

    Issue seem to be introduced by 63c882a0 (inotify: reimplement inotify
    using fsnotify) after 2.6.30.

    Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
    Eric Paris <eparis@parisplace.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Eric Paris <eparis@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/notify/inotify/inotify_fsnotify.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/fs/notify/inotify/inotify_fsnotify.c
    +++ b/fs/notify/inotify/inotify_fsnotify.c
    @@ -28,6 +28,7 @@
    #include <linux/path.h> /* struct path */
    #include <linux/slab.h> /* kmem_* */
    #include <linux/types.h>
    +#include <linux/sched.h>

    #include "inotify.h"

    @@ -146,6 +147,7 @@ static void inotify_free_group_priv(stru
    idr_for_each(&group->inotify_data.idr, idr_callback, group);
    idr_remove_all(&group->inotify_data.idr);
    idr_destroy(&group->inotify_data.idr);
    + free_uid(group->inotify_data.user);
    }

    void inotify_free_event_priv(struct fsnotify_event_private_data *fsn_event_priv)



    \
     
     \ /
      Last update: 2010-05-25 01:31    [W:0.021 / U:0.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site