lkml.org 
[lkml]   [2010]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning
On Mon, May 24, 2010 at 11:23:55AM +0800, Ming Lei wrote:
> On Sun, 23 May 2010 20:47:46 +0100
> Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> > Moreover, I put to you that it's utterly pointless - and a waste of
> > CPU time - telling lockdep about the IRQ masking when an exception
>
> Yes, the patch still tries to remove the pointless trace of IRQ masking,
> such as: replace disable_irq with disable_irq_notrace.
>
> > occurs, and it's also pointless telling lockdep about the IRQ
> > unmasking when we resume userspace.
>
> Even it is pointless, but if lockdep doesn't see the IRQ unmasking, the
> warning "unannotated irqs-on" will be triggered and lockdep doe not work
> any longer, so we have to remove the warning to make lockdep workable on
> ARM, could you agree on it? It is the main purpose of the patch.

I'm sorry, I think we have a communication issue; you're not understanding
the points that I'm making. I feel I'm wasting my time trying to explain
it.

I'm not merging your patch as-is because I believe it to be wrong.


\
 
 \ /
  Last update: 2010-05-24 09:23    [W:0.083 / U:39.740 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site