lkml.org 
[lkml]   [2010]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] Add the viafb video capture driver
On Sun, 23 May 2010 09:51:47 -0300
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:

> The driver is OK to my eyes. I just found 2 minor coding style issues.
> it is ok to me if you want to sent it via your git tree.
>
> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Great, thanks for taking a look!

All of the precursor stuff is in mainline now, so it can go via whatever
path. I'll just go ahead and request a pull in the near future unless
somebody objects.

> > + .sizeimage = VGA_WIDTH*VGA_HEIGHT*2,
>
> CodingStyle: please use spaces between values/operators. Not sure why, but
> newer versions of checkpatch.pl don't complain anymore on some cases.

Interesting...for all of my programming life I've left out spaces around
multiplicative operators - a way of showing that they bind more tightly
than the additive variety. I thought everybody else did that too.
CodingStyle agrees with you, though; I'll append a patch fixing these up.
Learn something every day...

Thanks,

jon


\
 
 \ /
  Last update: 2010-05-25 01:25    [W:0.044 / U:31.352 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site