[lkml]   [2010]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[02/34] hp_accel: fix race in device removal
2.6.34-stable review patch.  If anyone has any objections, please let us know.


From: Oliver Neukum <>

commit 06efbeb4a47b6f865e1c9d175ab9d6e90b69ae9e upstream.

The work queue has to be flushed after the device has been made
inaccessible. The patch closes a window during which a work queue might
remain active after the device is removed and would then lead to ACPI
calls with undefined behavior.

Signed-off-by: Oliver Neukum <>
Acked-by: Eric Piel <>
Acked-by: Pavel Machek <>
Cc: Pavel Herrmann <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/hwmon/hp_accel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/hwmon/hp_accel.c
+++ b/drivers/hwmon/hp_accel.c
@@ -324,8 +324,8 @@ static int lis3lv02d_remove(struct acpi_

- flush_work(&;
+ flush_work(&;

return lis3lv02d_remove_fs(&lis3_dev);

 \ /
  Last update: 2010-05-25 01:19    [W:0.104 / U:4.064 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site