lkml.org 
[lkml]   [2010]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] KVM: MMU: allow more page become unsync at gfn mapping time


Avi Kivity wrote:
> On 05/24/2010 05:03 AM, Xiao Guangrong wrote:
>>
>> Avi Kivity wrote:
>>
>>
>>>> + if (need_unsync)
>>>> + kvm_unsync_pages(vcpu, gfn);
>>>> return 0;
>>>> }
>>>>
>>>>
>>>>
>>> Looks good, I'm just uncertain about role.invalid handling. What's the
>>> reasoning here?
>>>
>>>
>> Avi,
>>
>> Thanks for your reply.
>>
>> We no need worry about 'role.invalid' here, since we only allow the
>> PTE shadow
>> pages(role.level == 1) become unsync, and in current code,
>> 'role.invalid' is only
>> used for root shadow pages.
>>
>
> Right, the invlpg change is not it yet. But I think it should be in
> this patch; I don't like subtle dependencies, and it will make the
> invplg patch simpler.
>

OK, i'll fix those two patches, thanks


\
 
 \ /
  Last update: 2010-05-24 09:21    [W:0.031 / U:19.160 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site