Messages in this thread | | | Date | Mon, 24 May 2010 11:35:57 -0500 | Subject | Re: [dm-devel] [PATCH v3 3/3] dm: lookup devices by path with name_to_dev_t | From | Will Drewry <> |
| |
On Mon, May 24, 2010 at 10:07 AM, Alasdair G Kergon <agk@redhat.com> wrote: > On Mon, May 24, 2010 at 09:44:07AM -0500, Will Drewry wrote: >> fwiw, the only reason for the copy was because |path| is a >> const in the function but not when passed to name_to_dev_t. >> I wasn't sure what the preferred practice was so I just duped >> the data needed. > > Well check that it is treated as 'const' and send a separate patch to > the maintainer to add const, perhaps? If it isn't const (why would > that be?), then yes we'd need to copy it.
I'll cross-check the code again and send a patch out if it looks like it is const-safe.
thanks, will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |