[lkml]   [2010]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH -mm 1/1] ptrace: PTRACE_GETFDPIC: fix the unsafe usage of child->mm
Oleg Nesterov <> wrote:

> Now that Mike Frysinger unified the FDPIC ptrace code, we can fix
> the unsafe usage of child->mm in ptrace_request(PTRACE_GETFDPIC).
> We have the reference to task_struct, and ptrace_check_attach()
> verified the tracee is stopped. But nothing can protect from
> SIGKILL after that, we must not assume child->mm != NULL.
> Signed-off-by: Oleg Nesterov <>

Acked-by: David Howells <>

Does it make sense to move the call to get_task_mm() up to sys_ptrace() since
several ptrace functions use it? The mm pointer could then be handed down the
ptrace hierarchy.


 \ /
  Last update: 2010-05-24 16:39    [W:0.094 / U:20.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site