lkml.org 
[lkml]   [2010]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH -V11 1/9] exportfs: Return the minimum required handle size
Date
On Fri, 21 May 2010 18:15:16 -0400, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> On Thu, May 20, 2010 at 01:05:30PM +0530, Aneesh Kumar K.V wrote:
> > The exportfs encode handle function should return the minimum required
> > handle size. This helps user to find out the handle size by passing 0
> > handle size in the first step and then redoing to the call again with
> > the returned handle size value.
>
> The encode_fh() interface is a little confusing. (Not your fault,
> really, mainly it's the return value (and the special use of 255) that I
> always find odd.)
>
> But maybe it would help to have a little more documention in the
> export_encode_fh() kerneldoc comment and/or in
> Documentation/filesystems/nfs/Exporting?
>


Will update in the next iteration.

-aneesh


\
 
 \ /
  Last update: 2010-05-22 10:35    [from the cache]
©2003-2011 Jasper Spaans