Messages in this thread | | | Date | Sat, 22 May 2010 20:13:52 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/3] mm/swapfile.c: better messages for swap_info_get |
| |
From: Cesar Eduardo Barros <cesarb@cesarb.net> Date: Sat, May 22, 2010 at 03:08:49PM -0300
> swap_info_get() is used for more than swap_free(). > > Use "swap_info_get:" instead of "swap_free:" in the error messages. > > Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net> > --- > mm/swapfile.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 6cd0a8f..af7d499 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -522,16 +522,16 @@ static struct swap_info_struct *swap_info_get(swp_entry_t entry) > return p; > > bad_free: > - printk(KERN_ERR "swap_free: %s%08lx\n", Unused_offset, entry.val); > + printk(KERN_ERR "swap_info_get: %s%08lx\n", Unused_offset, entry.val);
Why not let the compiler do it for ya:
printk(KERN_ERR "%s: %s%08lx\n", __func__, Unused_offset, entry.val);
?... etc.
-- Regards/Gruss, Boris.
| |