lkml.org 
[lkml]   [2010]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PULL REQUEST] Ext2, ext3, and quota updates for 2.6.35-rc1
On Fri 21-05-10 11:50:15, Linus Torvalds wrote:
>
>
> On Fri, 21 May 2010, Jan Kara wrote:
> >
> > Oops, I've just found a bug in one of my ocfs2 fixes. I've fixed that up
> > so the new diffstat is here:
>
> I already pulled your previous version.
OK, I'll push the fix separately.

> And btw, Jan, I'm getting pretty upset with your apparently cavalier
> attitude to filesystems. We've had several bugs lately for some quota or
> filesystem "cleanups", which in at least one case caused corrupted
> filesystems etc.
That ext3 bug was nasty I agree :( I'm now pushing some quota tests to
XFSQA and setup a machine that runs them. So that should improve a test
coverage...

> You need to be a hell of a lot more careful, or I will have to stop
> pulling from you. Filesystem bugs are _major_ no-no's.
>
> How long had that buggy commit been tested? By who? Was it acked or
> reviewed by anybody else?
The buggy commit was "ocfs2: Fix lock inversion in quotas during umount"
and it was reviewed by Joel Becker. Neither of us realized that we have to
stop quota syncing thread also on remount read-only...

Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2010-05-21 21:27    [W:0.048 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site