Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH v2] ptrace: unify FDPIC implementations | Date | Fri, 21 May 2010 11:35:12 -0700 (PDT) |
| |
> This looks unsafe. What protect child->mm if ptrace() races with SIGKILL ? > > Of course, I do not blame this patch, the code was copied from arch/, but > I think we need another patch which checks ->mm != NULL under task_lock() > on top of this one?
Agreed, unless things are somehow different on nommu so there aren't such races. But, as you mention, this is a long-standing issue that is entirely unrelated to the cleanup here and should not delay merging this patch.
Thanks, Roland
| |