Messages in this thread | | | Subject | Re: [PATCH 2/2] perf: Drop the skip argument from perf_arch_fetch_regs_caller | From | Peter Zijlstra <> | Date | Fri, 21 May 2010 12:24:37 +0200 |
| |
On Fri, 2010-05-21 at 10:11 +0200, Frederic Weisbecker wrote: > +static inline void perf_fetch_caller_regs(struct pt_regs *regs) > { > - unsigned long ip; > - > memset(regs, 0, sizeof(*regs));
btw, do we really need that memset?
As long as we don't actually copy out to userspace, it really doesn't matter what is in there, and we should be setting all relevant registers anyway.
| |