lkml.org 
[lkml]   [2010]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] perf: Drop the skip argument from perf_arch_fetch_regs_caller
From
Date
On Fri, 2010-05-21 at 10:11 +0200, Frederic Weisbecker wrote:
> +static inline void perf_fetch_caller_regs(struct pt_regs *regs)
> {
> - unsigned long ip;
> -
> memset(regs, 0, sizeof(*regs));

btw, do we really need that memset?

As long as we don't actually copy out to userspace, it really doesn't
matter what is in there, and we should be setting all relevant registers
anyway.



\
 
 \ /
  Last update: 2010-05-21 12:27    [W:0.042 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site