lkml.org 
[lkml]   [2010]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vhost: Storage class should be before const qualifier
On 2010-05-17 at 15:54:57 +0200, Joe Perches <joe@perches.com> wrote:
> On Mon, 2010-05-17 at 15:27 +0200, Tobias Klauser wrote:
> > On 2010-05-17 at 15:13:35 +0200, Michael S. Tsirkin <mst@redhat.com> wrote:
> > > On Mon, May 17, 2010 at 03:12:49PM +0200, Tobias Klauser wrote:
> > > > The C99 specification states in section 6.11.5:
> > > > The placement of a storage-class specifier other than at the beginning
> > > > of the declaration specifiers in a declaration is an obsolescent
> > > > feature.
> > > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> > > Just to clarify: does some compiler/checker actually barf on this?
> > GCC does emit a warning if the options '-std=c99 -W -Wall' are present.
> > ICC also does warn about this, though I don't know whether this depends
> > on any commandline options.
>
> Perhaps others should be converted as well.
>
> $ grep -rPl --include=*.[ch] "^[ \t]*const\s+static" * | \
> xargs sed -i -r -e 's/^[ \t]*const[ \t]+static\b/static const/g'

Thanks, I slightly modified this (to preserve possible whitespaces at
the beginning of the line) and will submit the patches to the respective
maintainers/mailinglists.

Tobias


\
 
 \ /
  Last update: 2010-05-20 10:03    [W:1.399 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site