Messages in this thread | | | Date | Thu, 20 May 2010 22:46:56 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 2/3] posix_timer: fix error path in timer_create |
| |
On Thu, 20 May 2010, Andrew Morton wrote:
> On Mon, 17 May 2010 21:18:07 +0400 > Andrey Vagin <avagin@openvz.org> wrote: > > > move CLOCK_DISPATCH(which_clock, timer_create, (new_timer)) after all > > posible EFAULT erros. > > > > *_timer_create may allocate/get resources. > > (for example posix_cpu_timer_create does get_task_struct) > > > > You've added a Cc:stable@kernel.org to the mail headers, but there is > no "Cc: <stable@kernel.org>" in the changelog. Please, if you think a > patch should go into -stable then add the tag to the changelog also - > this is more reliable and explicit than spraying things at a mailing > list. > > You cc'ed stable@kernel.org on all three patches but IMO only [2/3] > (this patch) is needed in -stable. > > And afaict, the bug which this patch fixes will allow a suitably-nasty > unprivileged application to leak an unbounded number of task-structs, > which is a box-killing local DoS. So yes, -stable wants this.
I'm adding it to 2/3 only. Have that lot queued up already.
Thanks,
tglx
| |