lkml.org 
[lkml]   [2010]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/8] USB: gadget: f_fs: use usb_string_ids_n()
    Hello.

    Michal Nazarewicz wrote:

    > Use usb_string_ids_n() function to simplify string ids
    > registeration.
    >
    > Signed-off-by: Michal Nazarewicz <m.nazarewicz@samsung.com>
    > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
    [...]
    > diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget/f_fs.c
    > index 3fe120f..ffc0001 100644
    > --- a/drivers/usb/gadget/f_fs.c
    > +++ b/drivers/usb/gadget/f_fs.c
    [...]
    > @@ -1393,25 +1396,17 @@ static int functionfs_bind(struct ffs_data *ffs, struct usb_composite_dev *cdev)
    > ffs->ep0req->complete = ffs_ep0_complete;
    > ffs->ep0req->context = ffs;
    >
    > - /* Get strings identifiers */
    > - for (count = ffs->strings_count, i = 0; i < count; ++i) {
    > - struct usb_gadget_strings **lang;
    > -
    > - int id = usb_string_id(cdev);
    > - if (unlikely(id < 0)) {
    > - usb_ep_free_request(cdev->gadget->ep0, ffs->ep0req);
    > - ffs->ep0req = NULL;
    > - return id;
    > + lang = ffs->stringtabs;
    > + while (*lang) {
    > + struct usb_string *str = (*lang)->strings;
    > + int id = first_id;
    > + for (; str->s; ++id, ++str) {
    > + str->id = id;
    > }

    {} not needed here.

    WBR, Sergei


    \
     
     \ /
      Last update: 2010-05-20 19:05    [W:0.037 / U:63.740 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site