Messages in this thread | | | From | H Hartley Sweeten <> | Date | Sun, 2 May 2010 12:35:51 -0500 | Subject | RE: [PATCH] Staging: dt3155: Cleanup memory mapped i/o access |
| |
On Friday, April 30, 2010 2:57 PM, Greg KH wrote: > On Wed, Apr 28, 2010 at 12:23:09PM -0500, H Hartley Sweeten wrote: >> The macros ReadMReg and WriteMReg are really just private versions of >> the kernel's readl and writel functions. Use the kernel's functions >> instead. And since ioremap returns a (void __iomem *) not a (u8 *), >> change all the uses of dt3155_lbase to reflect this. >> >> While here, make dt3155_lbase static since it is only used in the >> dt3155_drv.c file. Also, remove the global variable dt3155_bbase >> since it is not used anywhere in the code. >> >> Where is makes sense, create a local 'mmio' variable instead of using >> dt3155_lbase[minor] to make the code more readable. >> >> This change also affects the {Read|Write}I2C functions so they are >> also modified as needed. >> >> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> >> Cc: Greg Kroah-Hartman <gregkh@suse.de> >> Cc: Scott Smedley <ss@aao.gov.au> >> >> --- a/drivers/staging/dt3155/dt3155_drv.c > > This doesn't apply at all against the latest linux-next tree. Care to > redo it and resend it (not in base64 please.)
Hmm... Strange, I just rechecked the patch against next-20100430. It applied with no issues.
I'll resend in just a bit. Hopefully this is just a mail issue.
> thanks, > > greg k-h
Regards, Hartley
| |