Messages in this thread | | | Date | Wed, 19 May 2010 13:06:01 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 1/2] Hyperv detection - code cleanup |
| |
On 05/19/2010 11:47 AM, Avi Kivity wrote: > On 05/19/2010 08:51 PM, H. Peter Anvin wrote: >> On 05/19/2010 10:12 AM, Ky Srinivasan wrote: >> >>> From: K. Y. Srinivasan<ksrinivasan@novell.com> >>> Subject: Code cleanup - consolidate all hyperv related definitions into one >>> header file. >>> >>> >> How will this affect KVM? I was under the impression that this was >> separated out as a constants-only header file for a reason. > > It's exported, so any types need to be compatible with userspace (i.e. > __u32). >
... and certainly no prototypes for kernel-only functionality. Right, that's what I thought. So NAK on this patch, too.
-hpa
| |