Messages in this thread | | | From | Thomas Renninger <> | Subject | Re: [PATCH 4/4] omap: cpu: Power tracking support for cgroup cpuacct | Date | Wed, 19 May 2010 17:34:27 +0200 |
| |
On Wednesday 19 May 2010 15:11:03 Nishanth Menon wrote: > Mike Chan had written, on 05/18/2010 08:30 PM, the following: > > Specify new power field in struct omap_opp, which is > > power exported in milliWatt. ... > > + totalpower += cpuacct_freq[i] * mpu_opps[i + 1].power; ... > > + unsigned long power; /* power consumed running at OPP in milliWatts */ > > this conflicts with the OPP layer implementation. this structure will > disappear for good. Ah yes, another question: The power variable in struct omap_opp never gets initialized with a sane value, something is wrong...
Thomas
| |