lkml.org 
[lkml]   [2010]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/4] omap: cpu: Power tracking support for cgroup cpuacct
Date
On Wednesday 19 May 2010 15:11:03 Nishanth Menon wrote:
> Mike Chan had written, on 05/18/2010 08:30 PM, the following:
> > Specify new power field in struct omap_opp, which is
> > power exported in milliWatt.
...
> > + totalpower += cpuacct_freq[i] * mpu_opps[i + 1].power;
...
> > + unsigned long power; /* power consumed running at OPP in
milliWatts */
>
> this conflicts with the OPP layer implementation. this structure will
> disappear for good.
Ah yes, another question:
The power variable in struct omap_opp never gets initialized
with a sane value, something is wrong...

Thomas


\
 
 \ /
  Last update: 2010-05-19 17:35    [W:0.075 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site