lkml.org 
[lkml]   [2010]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 10/13] trace: Common code for kprobes/uprobes traceevents
Srikar Dronamraju wrote:
>>
>> Isn't it a common header for kprobes and uprobes? :)
>>
>> Maybe "Probe-based dynamic events common header" ?
>>
>
> Agree.
>
>>> +#define MAX_TRACE_ARGS 128
>>> +#define MAX_ARGSTR_LEN 63
>>> +#define MAX_EVENT_NAME_LEN 64
>>> +#define UPROBE_EVENT_SYSTEM "uprobes"
>>
>> You should *just move* the common code in this patch.
>> Additional uprobes code can be introduced in next patch.
>>
>
> Okay.
>
>>> +
>>> +/* Flags for trace_probe */
>>> +#define TP_FLAG_TRACE 1
>>> +#define TP_FLAG_PROFILE 2
>>> +#define UPROBE_ENABLED 4
>>
>> If this is a trace_probe flag, it is better to start with TP_FLAG_.
>
> Okay.
> Does TP_FLAG_UPROBE sound fine?

Sure, that's good for me:)

Thank you,


--
Masami Hiramatsu
e-mail: mhiramat@redhat.com


\
 
 \ /
  Last update: 2010-05-19 16:47    [W:0.054 / U:1.120 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site