lkml.org 
[lkml]   [2010]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH -V8 2/9] vfs: Add name to file handle conversion support
Date

"Aneesh Kumar K. V":
> How about the below patch ?
>
> commit 5f421ffbe9dd7bb84c5992b1725c06b511bc76d8
> Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Date: Wed May 19 14:52:44 2010 +0530
>
> vfs: Return ENOSYS if CONFIG_EXPORTFS is not enabled

Of course, I have no objection. :-)

Let me make sure some other issues.
If a malicious user passes altered dirfd or handle parameters, then
these things may happen.
- opens another file.
But it should not be a security hole, because finish_open_handle()
calls may_open() and the permission bits are tested expectedly.
- kernel crashes.
If s_export_op->fh_to_dentry() expects the passed handle is always
correct, then it may crash. But this is a problem of FS, instead of
open_by_handle().
- returns an error.
It is a matter of the application.
Right?

And the decode routine may return an anonymous (disconnected) dentry.
In this case, if LSM detects something wrong and produces a message,
then the filename will not be printed correctly.
This is not a problem of open_by_handle() either. Right?


J. R. Okajima


\
 
 \ /
  Last update: 2010-05-19 15:59    [W:0.102 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site