lkml.org 
[lkml]   [2010]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [LKML] Re: [PATCH v3] ad7877: keep dma rx buffers in seperate cache lines
    On Wed, May 19, 2010 at 11:36:56PM +1000, Nick Piggin wrote:
    > On Wed, May 19, 2010 at 02:17:47PM +0100, David Woodhouse wrote:
    > >
    > > The 'cacheline aligned' misconception did manage to get into the ad7877
    > > driver in commit 3843384a though -- it now uses ____cacheline_aligned
    > > instead of __attribute__((__aligned__(ARCH_KMALLOC_MINALIGN))) as it
    > > should.
    >
    > OK so long as there is not a "must be cacheline aligned" requirement.
    > Your proposal for a __dma_aligned attribute in an arch header looks
    > like a good idea there.

    Would you happen to know of other potential users? At this point I'd
    much rather just allocate the buffers dynamically and hide the issue
    nicely behind kmalloc().


    \
     
     \ /
      Last update: 2010-05-19 15:47    [W:4.070 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site