Messages in this thread | | | Date | Wed, 19 May 2010 15:44:30 +0200 | From | Johannes Weiner <> | Subject | Re: [LKML] Re: [PATCH v3] ad7877: keep dma rx buffers in seperate cache lines |
| |
On Wed, May 19, 2010 at 11:36:56PM +1000, Nick Piggin wrote: > On Wed, May 19, 2010 at 02:17:47PM +0100, David Woodhouse wrote: > > > > The 'cacheline aligned' misconception did manage to get into the ad7877 > > driver in commit 3843384a though -- it now uses ____cacheline_aligned > > instead of __attribute__((__aligned__(ARCH_KMALLOC_MINALIGN))) as it > > should. > > OK so long as there is not a "must be cacheline aligned" requirement. > Your proposal for a __dma_aligned attribute in an arch header looks > like a good idea there.
Would you happen to know of other potential users? At this point I'd much rather just allocate the buffers dynamically and hide the issue nicely behind kmalloc().
| |